HIVE-23786: HMS server side filter with Ranger #1221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvary
reviewed
Jul 8, 2020
...org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientGetPartitionsTempTable.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 8, 2020
...org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientGetPartitionsTempTable.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 8, 2020
...oop/hive/ql/security/authorization/plugin/metastore/filtercontext/DatabaseFilterContext.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 8, 2020
...ache/hadoop/hive/ql/security/authorization/plugin/metastore/TestHiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 8, 2020
...etastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 8, 2020
...etastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 8, 2020
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 8, 2020
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 8, 2020
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 8, 2020
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Show resolved
Hide resolved
pvary
reviewed
Jul 8, 2020
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 8, 2020
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 8, 2020
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
|
I have done a first sweeping review. A few asks:
As I am not too familiar with Ranger, please find a reviewer on that regard as well please. Thanks for the patch. We really need these checks on HMS side as well. |
|
One more thing: Do I remember correctly, that all the logs are on debug level? I think it would be good to have 1 or 2 log lines in info level, just t confirm that everything is good. Like "Filtered out 2 tables from 1000", or whatever... |
kgyrtkirk
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
pvary
reviewed
Jul 22, 2020
...org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/events/ReadTableEvent.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 22, 2020
...org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/events/ReadTableEvent.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 22, 2020
...etastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 22, 2020
...etastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 22, 2020
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Show resolved
Hide resolved
pvary
reviewed
Jul 29, 2020
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 29, 2020
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 29, 2020
...hadoop/hive/ql/security/authorization/plugin/metastore/filtercontext/TableFilterContext.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 29, 2020
...hadoop/hive/ql/security/authorization/plugin/metastore/filtercontext/TableFilterContext.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jul 29, 2020
...etastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests passed
tests pending
tests failed
and removed
tests pending
tests passed
tests failed
labels
sam-an-cloudera
force-pushed
the
hive23786
branch
from
6548f9f
to
15ec759
Compare
kgyrtkirk
added
tests failed
tests pending
tests unstable
tests passed
and removed
tests pending
tests failed
tests unstable
labels
pvary
approved these changes
Aug 3, 2020
|
Fix has been merged into master. Thanks for the patch @sam-an-cloudera |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIVE-23786