[HIVE-15727] Adding pre insert work and block insert intot statement #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-slim
changed the title
b-slim
force-pushed
the
HIVE-15727-block-insert-into
branch
from
68be75b
to
88d0ff5
Compare
ashutoshc
suggested changes
Jan 31, 2017
| * | ||
| * @throws MetaException | ||
| */ | ||
| void preInsertTable(Table table, boolean overwrite) throws MetaException; |
There was a problem hiding this comment.
I think this method doesn't belong in this interface. Since, this is not called when we are making metadata calls, instead this is tied to query lifecycle.
I think this should be added to StorageHandler interface and then in DDLTask execute(), should get called as table.getStorageHandler().preInsert()
There was a problem hiding this comment.
@ashutoshc would this also to the function InsertTable added in the previous PR ?
| @@ -2216,6 +2216,16 @@ public void addDynamicPartitions(long txnId, String dbName, String tableName, | |||
| } | |||
|
|
|||
| @Override | |||
| public void preInsertTable(Table table, boolean overwrite) throws MetaException { | |||
There was a problem hiding this comment.
Better to pass in PreInsertTableDesc object instead of 2 arguments. Helps in evolving interface better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.