HIVE-15910: Improvements in Hive Unit Test by using In-memory Derby DB #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejasmn
reviewed
Feb 16, 2017
| @@ -102,6 +102,11 @@ protected CompactorTest() throws Exception { | |||
| tmpdir.deleteOnExit(); | |||
| } | |||
|
|
|||
| protected void deleteTableDir(String tableName) throws IOException { | |||
There was a problem hiding this comment.
Just doing a org.apache.commons.io.FileUtils.deleteDirectory(tmpdir) before tmpdir.mkdir() would be a simple solution, as all files are being created under that dir. With that the individual deleteTableDir calls won't be needed.
Also, the path could be made unique by using Files.createTempDirectory, so that concurrent running of tests won't step on each other.
There was a problem hiding this comment.
I agree with temp directory creation using Files.createTempDirectory. With this, we can ensure both concurrent and repeated calls won't end up with same directory. Also, will delete the temp directory as part of tearDown itself to avoid creating too many directories.
|
Already committed to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.