Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-15929. Fix HiveDecimalWritable compatibility with Hive 2.1. #149

Closed
wants to merge 1 commit into from

Conversation

omalley
Copy link
Contributor

@omalley omalley commented Feb 15, 2017

This allows Hive 2.1 to work without getting an exception.

Copy link
Contributor

@prasanthj prasanthj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I just checked the old implementation where it returns internalStorage byte[] which could be of different size. But now we are returning byte[] of length 0.

@omalley
Copy link
Contributor Author

omalley commented Feb 15, 2017

Ok, since the calling code will just allocate an array the size it wants, I made a static final with the empty array.

Copy link
Contributor

@prasanthj prasanthj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in 74c5045 Feb 16, 2017
asfgit pushed a commit that referenced this pull request Feb 16, 2017
Fixes #149

Signed-off-by: Owen O'Malley <omalley@apache.org>
asfgit pushed a commit that referenced this pull request Apr 26, 2017
Fixes #149

Signed-off-by: Owen O'Malley <omalley@apache.org>
omalley added a commit to omalley/hive that referenced this pull request May 25, 2017
Fixes apache#149

Signed-off-by: Owen O'Malley <omalley@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants