Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-23962 Make bin/hive pick user defined jdbc url #1591

Merged
merged 2 commits into from Oct 21, 2020

Conversation

nrg4878
Copy link
Contributor

@nrg4878 nrg4878 commented Oct 20, 2020

SAME AS PR#1344 initially submitted by Xiaomeng. I am just rebasing the patch as the old PR is auto-closed. Looking for a clean test run.

Add an env variable BEELINE_URL_LEGACY, when this value is not empty,
run "beeline -c $BEELINE_URL_LEGACY".

Add an env variable BEELINE_URL_LEGACY, when this value is not empty,
run "beeline -c $BEELINE_URL_LEGACY".
@nrg4878
Copy link
Contributor Author

nrg4878 commented Oct 20, 2020

the original fix was authored by Xiaomeng Zhang which I had reviewed. So will submit this fix

Copy link
Contributor

@vihangk1 vihangk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good to me.

@vihangk1 vihangk1 merged commit 3f9cf38 into apache:master Oct 21, 2020
@nrg4878
Copy link
Contributor Author

nrg4878 commented Oct 21, 2020

Thanks Vihang for the review and commit.

pvargacl pushed a commit to pvargacl/hive that referenced this pull request Oct 28, 2020
…d Xiaomeng Zhang, reviewed by Vihang Karajgaonkar)

closes apache#1591
szehon-ho pushed a commit to szehon-ho/hive that referenced this pull request Nov 25, 2020
…d Xiaomeng Zhang, reviewed by Vihang Karajgaonkar)

closes apache#1591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants