HIVE-24333 Cut long methods in Driver to smaller, more manageable pieces (Miklos Gergely) #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belugabehr
reviewed
Nov 10, 2020
belugabehr
reviewed
Nov 10, 2020
belugabehr
reviewed
Nov 10, 2020
belugabehr
reviewed
Nov 10, 2020
belugabehr
requested changes
Nov 10, 2020
miklosgergely
force-pushed
the
HIVE-24333
branch
from
7316cc9
to
8c33879
Compare
miklosgergely
force-pushed
the
HIVE-24333
branch
from
8c33879
to
4e7e1d8
Compare
kgyrtkirk
added
tests failed
tests pending
tests passed
and removed
tests pending
tests failed
labels
…ces (Miklos Gergely)
miklosgergely
force-pushed
the
HIVE-24333
branch
from
4e7e1d8
to
76ce45d
Compare
kgyrtkirk
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
belugabehr
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The Driver class has some very long methods, they are now having a more manageable size. Also some minor checkstyle errors were fixed in some Driver associated classes
Why are the changes needed?
To make the Driver class more understandable.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
All the tests are still running.