New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-24230 Integrate HPL/SQL into HiveServer2 (amagyar) #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustafaiman
reviewed
Oct 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the changes in ql and service directory. Left mostly minor comments.
One question: does existing hplsql tests use the new mechanism now?
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java
Outdated
Show resolved
Hide resolved
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java
Show resolved
Hide resolved
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java
Show resolved
Hide resolved
service/src/java/org/apache/hive/service/cli/operation/hplsql/HplSqlOperation.java
Show resolved
Hide resolved
service/src/java/org/apache/hive/service/cli/operation/hplsql/HplSqlQueryExecutor.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests pending
tests unstable
tests failed
and removed
tests unstable
tests pending
labels
Nov 2, 2020
kgyrtkirk
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
Nov 9, 2020
kgyrtkirk
reviewed
Nov 12, 2020
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java
Outdated
Show resolved
Hide resolved
service/src/java/org/apache/hive/service/cli/operation/hplsql/HplSqlQueryExecutor.java
Show resolved
Hide resolved
service/src/java/org/apache/hive/service/cli/operation/hplsql/Udf.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
Nov 12, 2020
kgyrtkirk
added
tests pending
tests unstable
tests passed
and removed
tests passed
tests pending
tests unstable
labels
Nov 12, 2020
kgyrtkirk
reviewed
Nov 20, 2020
hplsql/src/main/java/org/apache/hive/hplsql/executor/JdbcQueryExecutor.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
Nov 23, 2020
kgyrtkirk
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See HIVE-24230 for more info.