HIVE-24397 : Add the projection specification to the table request object and add placeholders in ObjectStore.java #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
vnhive
changed the title
kgyrtkirk
added
tests pending
tests failed
tests unstable
tests passed
and removed
tests passed
tests pending
tests failed
tests unstable
labels
vnhive
changed the title
kgyrtkirk
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
…ject and add placeholders in ObjectStore.java
…ject and add placeholders in ObjectStore.java Implement the placeholders in ObjectStore.java
…ject and add placeholders in ObjectStore.java When the projection specification is NULL, all the tables should be returned. Update the test case in TestTablesGetExists.java to reflect this.
…ject and add placeholders in ObjectStore.java Remove whitespace diff in TestGetPartitionsUsingProjectionAndFilterSpecs.java
…ject and add placeholders in ObjectStore.java Added capability to validate projection fields on the table.
…ject and add placeholders in ObjectStore.java Create the getTables method and change it to return a TablesResult instead of List<String>.
…ject and add placeholders in ObjectStore.java Addressing comments.
…ject and add placeholders in ObjectStore.java Addressing comments.
…ject and add placeholders in ObjectStore.java getTables API should not use Request and Result thrift objects.
…ject and add placeholders in ObjectStore.java Changed TestTablesGetExists back into a checkin test.
kgyrtkirk
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
nrg4878
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
@vnhive Change looks good to me. +1.
Could please create a sub-task for this jira to also provide a CachedStore implementation for this optimization. Metadata caching combined with projection filter support could improve performance dramatically. Thank you
|
Fix has been merged to master. Thank you @vnhive |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIVE-24397 : Add the projection specification to the table request object and add placeholders in ObjectStore.java
The GetProjectionsSpec object is added to GetTablesRequest. The projection specification are passed down
to the RawStore implementations to enable creating a subset of the columns that are returned.
This patch does not introduce any customer facing changes.