HIVE-24401: Fix HiveConf description #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests failed
tests unstable
tests passed
and removed
tests unstable
tests pending
tests failed
labels
|
@klcopp Could you review and merge this? Thanks. |
klcopp
reviewed
Nov 19, 2020
| "Means Major compaction on full CRUD tables is done as a query, " | ||
| + "and minor compaction will be disabled."), | ||
| "Means compaction on full CRUD tables is done as a query. " | ||
| + "Compactions on insert-only tables will always run as a query."), |
There was a problem hiding this comment.
Thanks for taking care of this!
I'd add to the end: "regardless of the value of this configuration" just so it's clear.
and "as a query" isn't exactly accurate, I'd change it to something like: "via queries"
pvargacl
force-pushed
the
confdescription
branch
from
8cf11a2
to
c225d52
Compare
pvargacl
force-pushed
the
confdescription
branch
from
c225d52
to
56f76e0
Compare
klcopp
approved these changes
Nov 19, 2020
|
Skipping tests as this is just a config change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix outdated description