HIVE-24411: Make ThreadPoolExecutorWithOomHook more awareness of OutO… #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
|
@kgyrtkirk could you please take a look? thanks! |
kgyrtkirk
approved these changes
Jan 26, 2021
|
sorry @dengzhhu653 ; I've missed your initial ping |
Thank you very much for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fMemoryError
What changes were proposed in this pull request?
Check the root cause of failed tasks to see if that is an instance of OutOfMemoryError.
Why are the changes needed?
Now the ThreadPoolExecutorWithOomHook invokes some oom hooks and stops the HiveServer2 in case of OutOfMemoryError when executing the tasks. The exception is obtained by calling method
future.get(), however the exception may never be an instance of OutOfMemoryError, as the exception is wrapped in ExecutionException, see the method report in class FutureTask.Does this PR introduce any user-facing change?
No
How was this patch tested?
unit test