HIVE-24424: Use PreparedStatements in DbNotificationListener getNextNLId #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
abstractdog
approved these changes
Nov 26, 2020
...erver-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
Outdated
Show resolved
Hide resolved
...erver-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
belugabehr
force-pushed
the
HIVE-24424
branch
from
a761597
to
6a72369
Compare
kgyrtkirk
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
|
Thanks @miklosgergely for the review. Can you please take a look once more? I believe I've addressed your comments. |
belugabehr
force-pushed
the
HIVE-24424
branch
from
6a72369
to
9349003
Compare
miklosgergely
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?