HIVE-24470: Separate HiveMetaStore Thrift and Driver logic #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataproc-metastore
changed the title
kgyrtkirk
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
dataproc-metastore
changed the title
kgyrtkirk
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
coufon
force-pushed
the
HIVE-24470
branch
2 times, most recently
from
a669fce
to
4742788
Compare
coufon
force-pushed
the
HIVE-24470
branch
3 times, most recently
from
c4db25d
to
9959e28
Compare
kgyrtkirk
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
dataproc-metastore
changed the title
coufon
force-pushed
the
HIVE-24470
branch
2 times, most recently
from
109f30b
to
7f1f72e
Compare
kgyrtkirk
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
|
Thanks for your contribution! I modified the commit message a bit since I thought it was easier to understand (Driver is a overloaded term in Hive and means other things). |
Thank you Vihang for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes/Copy of #1740 and #1777
What changes were proposed in this pull request?
Refactor HiveMetastore.HMSHandler into its own class
Why are the changes needed?
This will pave the way for cleaner changes since now we don't have the driver class nested with 10,000 line HMSHandler file so there is a clearer separation of duties.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests, building/running manually
Not additional tests were added since this was a pure refactoring