HIVE-24862: Fix race condition causing NPE during dynamic partition l… #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oading Change-Id: I855ee21653427d4cbd37a4c834fafb95f3d3a9e2
szlta
approved these changes
Mar 9, 2021
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
failed test "dynpart_sort_opt_bucketing" succeeds locally, rerunning the tests |
kgyrtkirk
added
tests unstable
tests pending
tests passed
and removed
tests pending
tests unstable
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oading
Change-Id: I855ee21653427d4cbd37a4c834fafb95f3d3a9e2
What changes were proposed in this pull request?
Making the newFiles array thread safe avoids potential race condition during dynamic partition load, which could lead to NPE/
Why are the changes needed?
Make the used list threadsafe.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually as testing this race-condition is quite difficult.