HIVE-24201: WorkloadManager can support delayed move if destination pool does not have enough sessions #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
|
@sankarh, Could you please review? |
kgyrtkirk
added
tests passed
tests pending
tests unstable
and removed
tests pending
tests passed
labels
sankarh
requested changes
Mar 19, 2021
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Outdated
Show resolved
Hide resolved
sankarh
changed the title
sankarh
reviewed
Apr 28, 2021
kgyrtkirk
added
tests unstable
tests pending
tests failed
and removed
tests pending
tests unstable
labels
kgyrtkirk
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
sankarh
reviewed
Apr 29, 2021
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TriggerValidatorRunnable.java
Outdated
Show resolved
Hide resolved
|
+1, Patch looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the Workload management move trigger kills the query being moved to a different pool if destination pool does not have enough capacity. This PR introduces a "delayed move" configuration which doesn't immediately kill the query when the destination pool is full but lets the query run in the source pool as long as possible. Workload manager will attempt the move to destination pool only when there is claim upon the source pool. Also, introduces additional options for retrying delayed moves periodically and moving the session to the destination pool after a specified amount of time (delayed move timeout).
Design Doc-
DelayedMoveDesign.docx
Why are the changes needed?
For better utilization of cluster resources.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test