HIVE-24887: HMSHandler.getDatabase() with no capabilities to call tra… #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nslation (Naveen Gangam)
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
|
Thanks for the review. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nslation (Naveen Gangam)
What changes were proposed in this pull request?
A minor change to have getDatabase() call call the translation layer even when client does not set the capabilities.
Another change is to make checkDeletePermissions in the storage based authorizer to be package visibility, much like the other check* methods on this class. This allows the subclasses to use this method as well.
Why are the changes needed?
Mostly consistency with other methods like createTable() etc.
Does this PR introduce any user-facing change?
Potentially, clients can see a different locationUri if their original database object had location from the managed warehouse. This old location will now be set as managedLocationUri.
How was this patch tested?
Manually.
Failed unit tests.