Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-24976: CBO: count(distinct) in a window function fails CBO #2155

Merged

Conversation

kasakrisz
Copy link
Contributor

@kasakrisz kasakrisz commented Apr 6, 2021

What changes were proposed in this pull request?

Enable usage of distinct in aggregate functions in windowing clause.
For vectorized mode it is still enabled for count only because it is not implemented for the rest of the functions.

Why are the changes needed?

SQL standard allows.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=windowing_count_distinct.q -pl itests/qtest -Pitests

@kasakrisz kasakrisz self-assigned this Apr 6, 2021
@kasakrisz kasakrisz requested a review from jcamachor April 6, 2021 13:47
Copy link
Contributor

@jcamachor jcamachor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (pending tests)

@kasakrisz kasakrisz force-pushed the HIVE-24976-master-cbo-count-distinct branch from c0fa605 to 9dd5c24 Compare April 7, 2021 10:45
@github-actions github-actions bot requested a review from jcamachor April 7, 2021 10:45
@kasakrisz kasakrisz merged commit 71d5f58 into apache:master Apr 8, 2021
@kasakrisz kasakrisz deleted the HIVE-24976-master-cbo-count-distinct branch May 4, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants