HIVE-24920: TRANSLATED_TO_EXTERNAL tables may write to the same location #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-en' into HIVE-24920-trans-ext
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
nrg4878
reviewed
May 21, 2021
ql/src/test/results/clientnegative/translated_external_rename.q.out
Outdated
Show resolved
Hide resolved
| @@ -822,7 +934,7 @@ private Table validateTablePaths(Table table) throws MetaException { | |||
| + table.getTableName() + ",location:" + tablePath + ",Database's managed warehouse:" + dbLocation); | |||
| } | |||
| } else { | |||
| if (FileUtils.isSubdirectory(whRootPath.toString(), tablePath.toString())) { | |||
| if (isExternalWarehouseSet() && FileUtils.isSubdirectory(whRootPath.toString(), tablePath.toString())) { | |||
There was a problem hiding this comment.
So we only care that an external table is outside the managed warehouse root. It does not have to be within the external warehouse. So even if external warehouse isnt set, we shouldnt have to reject a path so long as it is not in the managed warehouse root.
There was a problem hiding this comment.
I just bumped into this while fixing this issue - in case the externalWarehouse is not set both external and managed tables are placed at the same location with the default configs:
create external table te (a integer); // file:/data/hive/warehouse/t
desc formatted te;
[...]
| Location: | file:/data/hive/warehouse/te | NULL |
| Table Parameters: | NULL | NULL |
| | EXTERNAL | TRUE |
[...]
create table tm (a integer);
desc formatted tm;
[...]
| Location: | file:/data/hive/warehouse/tm | NULL |
| Table Type: | EXTERNAL_TABLE | NULL |
| | EXTERNAL | TRUE |
| | TRANSLATED_TO_EXTERNAL | TRUE |
[...]
the root cause of this is that
- in case the ext wh is not set - it will be the default whroot:
- managed location for both default and non-default dbs are under wh by default
since the managed location is the same I don't think checking that would make sense...
don't you think that the current change aligns with the existing decisions/behaiour/etc in the above case?
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
nrg4878
approved these changes
May 27, 2021
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?