HIVE-24537: Optimise locking in LlapTaskSchedulerService #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I91c004a06b35d60d11551c5fa04db7e6ba6f4550
kgyrtkirk
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
tests unstable
labels
kgyrtkirk
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
tests unstable
labels
|
Hey @mustafaiman @rbalamohan can you please take a look on this one? |
maheshk114
reviewed
May 25, 2021
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
Show resolved
Hide resolved
|
LGTM +1 |
|
Merged to master, thanks @maheshk114 for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I91c004a06b35d60d11551c5fa04db7e6ba6f4550
What changes were proposed in this pull request?
Optimise locking in LlapTaskSchedulerService
Why are the changes needed?
Perf optimization
Does this PR introduce any user-facing change?
No
How was this patch tested?
TestLlapTaskSchedulerService