HIVE-25250: Fix TestHS2ImpersonationWithRemoteMS.testImpersonation #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests unstable
tests failed
and removed
tests pending
tests unstable
tests failed
labels
ashish-kumar-sharma
force-pushed
the
HIVE-25250
branch
from
47604c3
to
266c1ca
Compare
|
@kgyrtkirk Could you please review the PR? |
|
please run a flaky check on your changes to prove that it fixes the issue |
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
Thanks for pointing to flaky check pipeline. I ran and got the green build there http://ci.hive.apache.org/job/hive-flaky-check/269/ Please review and merge the PR. |
|
I'm a little bit amazed that changing the default |
|
@kgyrtkirk completely aligned with you. So I have reverted the change and fix the test by adding retires with in the test cases. Got green build in flaky test also |
kgyrtkirk
approved these changes
Jun 25, 2021
|
thank you! |
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
@kgyrtkirk Could you please merge the PR? |
ashish-kumar-sharma
force-pushed
the
HIVE-25250
branch
from
8b42cb6
to
c578003
Compare
kgyrtkirk
added
tests pending
tests unstable
tests passed
and removed
tests unstable
tests pending
labels
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…hish Sharma, reviewed by Zoltan Haindrich) Signed-off-by: Sankar Hariappan <sankarh@apache.org> Closes (apache#2404)
amanraj2520
added a commit
to amanraj2520/hive
that referenced
this pull request
Dec 18, 2022
…hish Sharma, reviewed by Zoltan Haindrich) Signed-off-by: Sankar Hariappan <sankarh@apache.org> Closes (apache#2404) (cherry picked from commit dc8891e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix flaky test TestHS2ImpersonationWithRemoteMS.testImpersonation. It was already fixed as part of HIVE-25093 but that is not the right way to do. Raising the PR again to create separate patch.
Why are the changes needed?
It is failing intermittently and putting unwanted pressure on hive-precommit setup.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Yes