HIVE-25268: Restore the functionality of date_format UDF #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests failed
tests unstable
and removed
tests pending
tests failed
tests unstable
labels
guptanikhil007
commented
Jun 20, 2021
guptanikhil007
commented
Jun 20, 2021
guptanikhil007
changed the title
|
@zabetak @jcamachor @sankarh Please review the change in the APIs |
ashish-kumar-sharma
suggested changes
Jun 20, 2021
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateFormat.java
Outdated
Show resolved
Hide resolved
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDateFormat.java
Show resolved
Hide resolved
ashish-kumar-sharma
suggested changes
Jun 20, 2021
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateFormat.java
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateFormat.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateFormat.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateFormat.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
guptanikhil007
force-pushed
the
update_date_format
branch
from
2584095
to
5ff5d0f
Compare
kgyrtkirk
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
sankarh
reviewed
Jun 21, 2021
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateFormat.java
Outdated
Show resolved
Hide resolved
| select date_format('1800-01-14 01:01:10.123', 'yyyy-MM-dd HH:mm:ss.SSS z'); | ||
|
|
||
| set hive.local.time.zone=Africa/Johannesburg; | ||
| select date_format('1400-01-14 01:01:10.123', 'yyyy-MM-dd HH:mm:ss.SSS z'); |
There was a problem hiding this comment.
Do we have tests for other formats (to ensure DateTimeFormat doesn't break anything)? Also need update of wiki doc.
There was a problem hiding this comment.
All the existing tests with SimpleDateFormat Formatter is passing except the milliseconds change which I have mentioned in my comment.
There was a problem hiding this comment.
Once this patch is merged I will update the Hive wiki as well
There was a problem hiding this comment.
+1 to @sankarh comments. Existing test cases are fine. Could please add some more time zone based test cases.
zabetak
approved these changes
Jun 25, 2021
guptanikhil007
force-pushed
the
update_date_format
branch
from
6c5d98b
to
a3f7007
Compare
|
Rebased on latest master |
kgyrtkirk
added
tests unstable
tests pending
tests failed
tests passed
and removed
tests pending
tests unstable
tests failed
labels
sankarh
approved these changes
Jun 28, 2021
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…1900 if the local timezone is other than UTC (Nikhil Gupta, reviewed by Ashish Sharma, Stamatis Zampetakis, Sankar Hariappan) Signed-off-by: Sankar Hariappan <sankarh@apache.org> Closes (apache#2409)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use new java time APIs to get the result instead of older APIs to restore functionality
Why are the changes needed?
date_format UDF gives
These changes fix both of the above issues
Does this PR introduce any user-facing change?
The functionality is restored for the date_format UDF
How was this patch tested?