HIVE-25288: Fix TestMmCompactorOnTez #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests failed
tests pending
tests passed
and removed
tests pending
tests failed
labels
pvary
reviewed
Jul 15, 2021
| @@ -85,6 +86,8 @@ public void setup() throws Exception { | |||
| hiveConf.setVar(HiveConf.ConfVars.METASTOREWAREHOUSE, TEST_WAREHOUSE_DIR); | |||
| hiveConf.setVar(HiveConf.ConfVars.HIVEINPUTFORMAT, HiveInputFormat.class.getName()); | |||
| hiveConf.setVar(HiveConf.ConfVars.HIVEFETCHTASKCONVERSION, "none"); | |||
| hiveConf.set(MetastoreConf.ConfVars.TXN_OPENTXN_TIMEOUT.getVarname(), "2000"); | |||
There was a problem hiding this comment.
We should use the code below to set MetastoreConf values to handle migration between HiveConf, MetastoreConf:
MetastoreConf.setVar(hiveConf, MetastoreConf.ConfVars.TXN_OPENTXN_TIMEOUT, "2000");
This is not too relevant here since this is only test code, but I prefer to stick to the standard way everywhere, so the next contributor will learn correctly.
pvary
reviewed
Jul 15, 2021
pvary
approved these changes
Jul 15, 2021
done |
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
zchovan
pushed a commit
to zchovan/hive
that referenced
this pull request
Jul 29, 2021
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fixed a bug caused by open txn commit timeout
Does this PR introduce any user-facing change?
No
How was this patch tested?
http://ci.hive.apache.org/job/hive-flaky-check/321