New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-25334: refactor timestamp UDF #2482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests failed
tests unstable
and removed
tests pending
tests failed
tests unstable
labels
Jul 15, 2021
ashish-kumar-sharma
force-pushed
the
HIVE-25334
branch
from
July 26, 2021 05:54
1e7caa9
to
52cf13f
Compare
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
Jul 26, 2021
kgyrtkirk
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
Jul 26, 2021
@zabetak @mattmccline-microsoft @adesh-rao Could you please review the PR? |
adesh-rao
reviewed
Jul 27, 2021
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java
Show resolved
Hide resolved
kgyrtkirk
added
tests unstable
tests pending
tests passed
and removed
tests unstable
tests pending
labels
Jul 27, 2021
adesh-rao
reviewed
Aug 3, 2021
sankarh
reviewed
Aug 6, 2021
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java
Show resolved
Hide resolved
sankarh
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
pvary
pushed a commit
to pvary/hive
that referenced
this pull request
Aug 24, 2021
…rma, reviewed by Adesh Rao, Sankar Hariappan) Signed-off-by: Sankar Hariappan <sankarh@apache.org> Closes (apache#2482)
pvary
pushed a commit
to pvary/hive
that referenced
this pull request
Aug 24, 2021
…rma, reviewed by Adesh Rao, Sankar Hariappan) Signed-off-by: Sankar Hariappan <sankarh@apache.org> Closes (apache#2482)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…rma, reviewed by Adesh Rao, Sankar Hariappan) Signed-off-by: Sankar Hariappan <sankarh@apache.org> Closes (apache#2482)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor cast(<> as timestamp)
Why are the changes needed?
Code and old and repetitive
Does this PR introduce any user-facing change?
No
How was this patch tested?
Yes