HIVE-25520 - Enable concatenate for external table. #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgaref
reviewed
Sep 20, 2021
...a/org/apache/hadoop/hive/ql/ddl/table/storage/concatenate/AlterTableConcatenateAnalyzer.java
Outdated
Show resolved
Hide resolved
| @@ -3254,6 +3254,8 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal | |||
|
|
|||
| TRANSACTIONAL_CONCATENATE_NOBLOCK("hive.transactional.concatenate.noblock", false, | |||
| "Will cause 'alter table T concatenate' to be non-blocking"), | |||
| ENABLE_CONCATENATE_FOR_EXTERNAL_TABLES("hive.concatenate.enable-external-tables", false, | |||
There was a problem hiding this comment.
Avoid using hyphen for HiveConf options: something like hive.external.concatenate would do.
Same for option: EXTERNAL_CONCATENATE is enough
...a/org/apache/hadoop/hive/ql/ddl/table/storage/concatenate/AlterTableConcatenateAnalyzer.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
…ed in code-review.
kgyrtkirk
added
tests pending
tests unstable
tests passed
and removed
tests unstable
tests pending
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.