Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport to 3: HIVE-24797: Disable validate default values when parsing Avro schemas #2670

Merged
merged 1 commit into from Oct 6, 2021
Merged

Backport to 3: HIVE-24797: Disable validate default values when parsing Avro schemas #2670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 8 additions & 6 deletions serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java
View file
Open in desktop
Expand Up @@ -276,28 +276,30 @@ public static HiveDecimal getHiveDecimalFromByteBuffer(ByteBuffer byteBuffer, in
return dec;
}

private static Schema.Parser getSchemaParser() {
// HIVE-24797: Disable validate default values when parsing Avro schemas.
return new Schema.Parser().setValidateDefaults(false);
}

public static Schema getSchemaFor(String str) {
Schema.Parser parser = new Schema.Parser();
Schema schema = parser.parse(str);
Schema schema = getSchemaParser().parse(str);
return schema;
}

public static Schema getSchemaFor(File file) {
Schema.Parser parser = new Schema.Parser();
Schema schema;
try {
schema = parser.parse(file);
schema = getSchemaParser().parse(file);
} catch (IOException e) {
throw new RuntimeException("Failed to parse Avro schema from " + file.getName(), e);
}
return schema;
}

public static Schema getSchemaFor(InputStream stream) {
Schema.Parser parser = new Schema.Parser();
Schema schema;
try {
schema = parser.parse(stream);
schema = getSchemaParser().parse(stream);
} catch (IOException e) {
throw new RuntimeException("Failed to parse Avro schema", e);
}
Expand Down