Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-25505: Incorrect results with header. skip.header.line.count if first line is blank #2717

Merged
merged 7 commits into from Oct 20, 2021
Merged

HIVE-25505: Incorrect results with header. skip.header.line.count if first line is blank #2717

merged 7 commits into from Oct 20, 2021

Conversation

pgaref
Copy link
Contributor

@pgaref pgaref commented Oct 12, 2021

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@pgaref
Copy link
Contributor Author

pgaref commented Oct 12, 2021

Hey @abstractdog can you take a look please?

@abstractdog
Copy link
Contributor

thanks @pgaref for the patch, the fix looks good to me!
however, I can see that it only applies to LLAP IO codepaths, I'm wondering if we're facing the same issue in tez container mode (with TestMiniTezCliDriver)

@pgaref
Copy link
Contributor Author

pgaref commented Oct 18, 2021

thanks @pgaref for the patch, the fix looks good to me! however, I can see that it only applies to LLAP IO codepaths, I'm wondering if we're facing the same issue in tez container mode (with TestMiniTezCliDriver)

Thanks @abstractdog for taking a look -- just added tests for Tez container mode both for plain an compressed files

@abstractdog
Copy link
Contributor

thanks @pgaref for the patch, the fix looks good to me! however, I can see that it only applies to LLAP IO codepaths, I'm wondering if we're facing the same issue in tez container mode (with TestMiniTezCliDriver)

Thanks @abstractdog for taking a look -- just added tests for Tez container mode both for plain an compressed files

thanks @pgaref , LGTM +1 pending tests

@pgaref pgaref closed this Oct 20, 2021
@pgaref pgaref reopened this Oct 20, 2021
@pgaref
HIVE-25505
65f4a14 
Incorrect results with header. skip.header.line.count if first line is blank

Change-Id: I51263bbbea86cf55fe739ca953eeef844f4c363f
@pgaref
Missing data
a3d9fa4 
Change-Id: Ic36c9cad224762f64be73230829e30665327f309
@pgaref
Fixing Tez mode
072b161 
Change-Id: I4be1edf18f6408c5e2fb401ebebf7ba6a9f6fc2b
@pgaref
Tez mode test
77a1a8c 
Change-Id: Ieaaa0a28069b87a36d8f2491f8ca67da0b3d4fa6
@pgaref
Trigger tests
c97ceaa 
Change-Id: I2b1703894f54e2b31374fe8959f21d150120fef7
@pgaref
Once again
34d9b68 
Change-Id: I02a4617a4b07e01561d5cb00d3bc1d2e99ee9b3c
@pgaref
Dopping table between runs
97b26ec 
Change-Id: Iee699b075c1e092c3a868d2fc6169cfc5a03fcde
@pgaref pgaref merged commit d4a61dd into apache:master Oct 20, 2021
HarshitGupta11 pushed a commit to HarshitGupta11/hive that referenced this pull request Dec 12, 2021
@pgaref @HarshitGupta11
HIVE-25505: Incorrect results with header. skip.header.line.count if …
cdfdfbe 
…first line is blank (Panos Garefalakis, reviewed by Laszlo Bodor)

Closes apache#2717
dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Dec 15, 2022
@pgaref @dengzhhu653
HIVE-25505: Incorrect results with header. skip.header.line.count if …
b0b1144 
…first line is blank (Panos Garefalakis, reviewed by Laszlo Bodor)

Closes apache#2717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abstractdog abstractdog abstractdog approved these changes

Assignees
No one assigned
Labels
tests passed
Projects
None yet
Milestone
No milestone
3 participants
@pgaref @abstractdog @kgyrtkirk