Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-25663 Need to modify table/partition lock acquisition retry for Zookeeper lock manager #2761

Closed
wants to merge 1 commit into from

Conversation

EugeneChung
Copy link

What changes were proposed in this pull request?

  • break out from retry loop when it meets unexpected exception
  • remove redundent logging, too

Why are the changes needed?

  • table/partition locks acquired for SQL are remained for a long time even though it is cancelled or timed out

Does this PR introduce any user-facing change?

No

How was this patch tested?

LOCK TABLE default.my_table PARTITION (log_date='2021-10-30') EXCLUSIVE;
SET hive.query.timeout.seconds=5;
SELECT * FROM default.my_table WHERE log_date='2021-10-30' LIMIT 10;

Then show locks shows the result.

Need to modify table/partition lock acquisition retry for Zookeeper lock manager
- break out from retry loop when it meets unexpected exception
- remove redundent logging, too
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

@github-actions github-actions bot added the stale label Dec 30, 2021
@github-actions github-actions bot closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants