Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-25681: Drop support for multi-threaded qtest execution via QTestRunnerUtils #2769

Merged
merged 1 commit into from Nov 15, 2021

Conversation

zabetak
Copy link
Contributor

@zabetak zabetak commented Nov 8, 2021

What changes were proposed in this pull request?

  1. Remove QTestRunnerUtils#queryListRunnerMultiThreaded and related code
  2. Remove (disabled) unit tests for this API (TestMTQueries).

Why are the changes needed?

Facilitate code evolution and maintenance.

The code is not being used by the current test infrastructure and this
is unlikely to change in the near future (especially after HIVE-22942).

Does this PR introduce any user-facing change?

No

How was this patch tested?

Cleanup refactoring no new tests needed.

…RunnerUtils

1. Remove QTestRunnerUtils#queryListRunnerMultiThreaded and related code
2. Remove (disabled) unit tests for this API (TestMTQueries).

The code is not being used by the current test infrastructure and this
is unlikely to change in the near future (especially after HIVE-22942).
Remove the code to facilitate code evolution and maintenance.
Copy link
Member

@kgyrtkirk kgyrtkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense to me - I think at best this might have some probabilistic chances to trigger some uncovered issues

@kgyrtkirk kgyrtkirk merged commit 03a2aa8 into apache:master Nov 15, 2021
HarshitGupta11 pushed a commit to HarshitGupta11/hive that referenced this pull request Dec 12, 2021
…RunnerUtils (apache#2769) (Stamatis Zampetakis reviewed by Zoltan Haindrich)

1. Remove QTestRunnerUtils#queryListRunnerMultiThreaded and related code
2. Remove (disabled) unit tests for this API (TestMTQueries).

The code is not being used by the current test infrastructure and this
is unlikely to change in the near future (especially after HIVE-22942).
Remove the code to facilitate code evolution and maintenance.
dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Dec 15, 2022
…RunnerUtils (apache#2769) (Stamatis Zampetakis reviewed by Zoltan Haindrich)

1. Remove QTestRunnerUtils#queryListRunnerMultiThreaded and related code
2. Remove (disabled) unit tests for this API (TestMTQueries).

The code is not being used by the current test infrastructure and this
is unlikely to change in the near future (especially after HIVE-22942).
Remove the code to facilitate code evolution and maintenance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants