HIVE-24390 Spelling common #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
|
it seems like there were some unrelated failures? I've restarted the tests |
kgyrtkirk
approved these changes
Dec 7, 2021
| @@ -5106,25 +5106,25 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal | |||
| "Specifies the minimum amount of tasks, executed by a particular LLAP daemon, before the health\n" + | |||
| "status of the node is examined."), | |||
| LLAP_NODEHEALTHCHECKS_MININTERVALDURATION( | |||
| "hive.llap.nodehealthckecks.minintervalduration", "300s", | |||
| "hive.llap.nodehealthchecks.minintervalduration", "300s", | |||
There was a problem hiding this comment.
actually; this is a breaking change - but I don't think anyone have ever changed these configs....so lets keep them
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
I've kicked off the tests once more - but the test failures seem to be releated to the changes; because the same set of tests failed. |
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR corrects misspellings identified by the check-spelling action in the
commondirectory (and a file namedcommon).Why are the changes needed?
Typos lead to all sorts of problems, branding errors, tests that don't test what's expected, difficulty in understanding both the code and the product.
Landing this would make it possible to extend the check-spelling workflow for the
common/directory (while guarding against additional typos in them once a directory's typos have been fixed). See #1674 (comment)Does this PR introduce any user-facing change?
Probably the changes in
common/src/java/org/apache/hadoop/hive/conf/HiveConf.javaHow was this patch tested?
The CI does testing (negative testing: jsoref@801665d#commitcomment-60756038; positive testing w/ this PR: jsoref@c1bd0cd) and the goal is to include it.
Depending on the order of things, this PR could be landed w/ the CI extension as well.