HIVE-25782: Added client capabilites in the dry run call for the CTAS… #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
previously approved these changes
Dec 9, 2021
JeongDaeKim
pushed a commit
to JeongDaeKim/hive
that referenced
this pull request
Dec 9, 2021
* HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Add table-level JVM lock on commits (apache#2547) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Core: Move ClientPool and ClientPoolImpl to core (apache#2491) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Improve code style (apache#2641) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Style: Delete blank line of CachedClientPool.java (apache#2787) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Fix some message typos in HiveCatalog: Matastore => Metastore (apache#2950) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Fix toString NPE with recommended constructor (apache#3021) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Build: Upgrade to Gradle 7.x (apache#2826) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Ensure tableLevelMutex is unlocked when uncommitted metadata delete fails (apache#3264) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Doc: refactor Hive documentation with catalog loading examples (apache#2544) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: unify catalog experience across engines (apache#2565) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Core: Add HadoopConfigurable interface to serialize custom FileIO (apache#2678) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Move Assert.assertTrue(..) instance checks to AssertJ assertions (apache#2756) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Core: Support multiple specs in OutputFileFactory (apache#2858) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - MR: Use SerializableTable in IcebergSplit (apache#2988) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Fix exception exception message in IcebergInputFormat (apache#3153) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Data: Fix equality deletes with date/time types (apache#3135) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Build: Fix ErrorProne UnnecessarilyQualified warnings (apache#3262) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Build: Fix ErrorProne NewHashMapInt warnings (apache#3260) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Core: Fail if both Catalog type and catalog-impl are configured (apache#3162) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - MR: Support imported data in InputFormat using name mapping (apache#3312) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Fix Catalog initialization without Configuration (apache#3252) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Switch to RetryingHMSClient (allows configuration of retryDelays and retries) (apache#3099) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Fix Catalogs.hiveCatalog method for default catalogs (apache#3338)
|
@saihemanth-cloudera there are no tests in this changeset - please add some |
HarshitGupta11
pushed a commit
to HarshitGupta11/hive
that referenced
this pull request
Dec 12, 2021
* HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Add table-level JVM lock on commits (apache#2547) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Core: Move ClientPool and ClientPoolImpl to core (apache#2491) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Improve code style (apache#2641) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Style: Delete blank line of CachedClientPool.java (apache#2787) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Fix some message typos in HiveCatalog: Matastore => Metastore (apache#2950) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Fix toString NPE with recommended constructor (apache#3021) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Build: Upgrade to Gradle 7.x (apache#2826) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Ensure tableLevelMutex is unlocked when uncommitted metadata delete fails (apache#3264) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Doc: refactor Hive documentation with catalog loading examples (apache#2544) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: unify catalog experience across engines (apache#2565) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Core: Add HadoopConfigurable interface to serialize custom FileIO (apache#2678) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Move Assert.assertTrue(..) instance checks to AssertJ assertions (apache#2756) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Core: Support multiple specs in OutputFileFactory (apache#2858) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - MR: Use SerializableTable in IcebergSplit (apache#2988) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Fix exception exception message in IcebergInputFormat (apache#3153) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Data: Fix equality deletes with date/time types (apache#3135) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Build: Fix ErrorProne UnnecessarilyQualified warnings (apache#3262) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Build: Fix ErrorProne NewHashMapInt warnings (apache#3260) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Core: Fail if both Catalog type and catalog-impl are configured (apache#3162) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - MR: Support imported data in InputFormat using name mapping (apache#3312) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Fix Catalog initialization without Configuration (apache#3252) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Switch to RetryingHMSClient (allows configuration of retryDelays and retries) (apache#3099) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Fix Catalogs.hiveCatalog method for default catalogs (apache#3338)
kgyrtkirk
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
|
the reported issue was that an unexpected exception was thrown - please add a test to check for that |
kgyrtkirk
requested changes
Dec 13, 2021
saihemanth-cloudera
force-pushed
the
hive-25782
branch
from
a9a5b5b
to
372faf7
Compare
kgyrtkirk
approved these changes
Dec 14, 2021
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
* HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Add table-level JVM lock on commits (apache#2547) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Core: Move ClientPool and ClientPoolImpl to core (apache#2491) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Improve code style (apache#2641) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Style: Delete blank line of CachedClientPool.java (apache#2787) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Fix some message typos in HiveCatalog: Matastore => Metastore (apache#2950) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Fix toString NPE with recommended constructor (apache#3021) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Build: Upgrade to Gradle 7.x (apache#2826) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Ensure tableLevelMutex is unlocked when uncommitted metadata delete fails (apache#3264) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Doc: refactor Hive documentation with catalog loading examples (apache#2544) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: unify catalog experience across engines (apache#2565) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Core: Add HadoopConfigurable interface to serialize custom FileIO (apache#2678) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Move Assert.assertTrue(..) instance checks to AssertJ assertions (apache#2756) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Core: Support multiple specs in OutputFileFactory (apache#2858) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - MR: Use SerializableTable in IcebergSplit (apache#2988) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Fix exception exception message in IcebergInputFormat (apache#3153) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Data: Fix equality deletes with date/time types (apache#3135) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Build: Fix ErrorProne UnnecessarilyQualified warnings (apache#3262) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Build: Fix ErrorProne NewHashMapInt warnings (apache#3260) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Core: Fail if both Catalog type and catalog-impl are configured (apache#3162) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - MR: Support imported data in InputFormat using name mapping (apache#3312) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Fix Catalog initialization without Configuration (apache#3252) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Switch to RetryingHMSClient (allows configuration of retryDelays and retries) (apache#3099) * HIVE-25613: Port Iceberg Hive fixes to the iceberg module Source Iceberg PR - Hive: Fix Catalogs.hiveCatalog method for default catalogs (apache#3338)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
apache#2858) (Sai Hemanth Gantasala reviewed by Zoltan Haindrich)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… query
What changes were proposed in this pull request?
Added client capabilities in the dry run for CTAS query.
Why are the changes needed?
The changes are required so that managed tables can be created with client capabilities.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Local machine, Remote cluster.