Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-25832:Exclude Category-X JDBC drivers from binary distribution #2905

Closed
wants to merge 1 commit into from
Closed

HIVE-25832:Exclude Category-X JDBC drivers from binary distribution #2905

wants to merge 1 commit into from

Conversation

zabetak
Copy link
Contributor

@zabetak zabetak commented Dec 22, 2021 •
edited

What changes were proposed in this pull request and why?

Exclude drivers for Oracle, MySQL, and MariaDB to avoid licensing violations.

Misc:

  1. Group all JDBC drivers in metastore-server pom.xml together for readability.
  2. Add MariaDB driver in metastore-server pom.xml for keeping things uniform.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Build binary distribution and manually inspect lib directory.

mvn clean package -DskipTests -Pdist
ls packaging/target/apache-hive-4.0.0-SNAPSHOT-bin/apache-hive-4.0.0-SNAPSHOT-bin/lib/ | grep -e "postgres" -e "ojdbc" -e "mssql" -e "mariadb" -e "derby" -e "mysql"

Do the same for metastore:

ls -l apache-hive-metastore-4.0.0-SNAPSHOT-bin/lib/ | grep -e "postgres" -e "ojdbc" -e "mssql" -e "mariadb" -e "derby" -e "mysql"
-rw-r--r-- 1 stamatis stamatis  3232158 Jan 22  2020 derby-10.14.1.0.jar
-rw-r--r-- 1 stamatis stamatis   792491 Jan 22  2020 mssql-jdbc-6.2.1.jre8.jar
-rw-r--r-- 1 stamatis stamatis   932808 Jan 22  2020 postgresql-42.2.14.jar

@zabetak
HIVE-25832:Exclude Category-X JDBC drivers from binary distribution
62912a4 
Exclude drivers for Oracle, MySQL, and MariaDB to avoid licensing
violations.

Misc:
1. Group all JDBC drivers in metastore-server pom.xml together for
readability.
2. Add MariaDB driver in metastore-server pom.xml for keeping things
uniform.
asolimando
asolimando approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@asolimando asolimando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zabetak zabetak closed this in 588e634 Jan 7, 2022
@zabetak zabetak deleted the HIVE-25832-jdbc-drivers-dist branch January 7, 2022 15:56
dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Dec 15, 2022
@zabetak @dengzhhu653
HIVE-25832: Exclude Category-X JDBC drivers from binary distribution …
da1c97a 
…(Stamatis Zampetakis, reviewed by Alessandro Solimando, Zoltan Haindrich)

Exclude drivers for Oracle, MySQL, and MariaDB to avoid licensing
violations.

Misc:
1. Group all JDBC drivers in metastore-server pom.xml together for
readability.
2. Add MariaDB driver in metastore-server pom.xml for keeping things
uniform.

Closes apache#2905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgyrtkirk kgyrtkirk kgyrtkirk approved these changes

@asolimando asolimando asolimando approved these changes

Assignees
No one assigned
Labels
tests passed
Projects
None yet
Milestone
No milestone
3 participants
@zabetak @kgyrtkirk @asolimando