HIVE-26000: DirectSQL to prune partitions fails with postgres backend for Skewed-Partition tables #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd for Skewed-Partition tables
pvary
approved these changes
Mar 3, 2022
nrg4878
approved these changes
Mar 3, 2022
@kgyrtkirk We already have testcase covering this scenario(list_bucket_dml_4.q), but directSql failure happens only with postgres db if column is not quoted. |
nareshpr
changed the title
zabetak
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
The fix looks reasonable to me so if it is tested locally I am fine merging this to master. Other than that having tests are good so following up on @kgyrtkirk comment I logged HIVE-26005. It would be nice to tackle this at some point but not necessarily as part of this PR.
|
Thanks for the review @zabetak. I verified the fix locally. |
marton-bod
approved these changes
Mar 7, 2022
|
please close this as I have merged to master this morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PartitionPruning via directSql is failing in postgres db for skewed tables
Why are the changes needed?
Fallback to ORM is taking long time
Does this PR introduce any user-facing change?
No
How was this patch tested?
We already have a testcase covering the issue (list_bucket_dml_4.q), it happens in postgres backend db.