HIVE-26023: Non blocking REPLACE, RENAME COLUMNS implementation #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests passed
and removed
tests pending
tests passed
labels
kgyrtkirk
added
tests unstable
tests pending
tests passed
and removed
tests pending
tests unstable
labels
veghlaci05
reviewed
May 2, 2022
| driver.getFetchTask().fetch(res); | ||
| swapTxnManager(txnMgr2); | ||
|
|
||
| FieldSetter.setField(txnMgr2, txnMgr2.getClass().getDeclaredField("numStatements"), 0); |
There was a problem hiding this comment.
txnMgr.acquireLocks increments the number of statements and that prevents us from calling it again - so doing a hard reset here.
Comment on lines
+3669
to
+4217
| checkLock(blocking ? LockType.EXCLUSIVE : LockType.EXCL_WRITE, | ||
| LockState.ACQUIRED, "default", "tab_acid", null, locks); |
There was a problem hiding this comment.
This could be changed to sth like
checkLock(blocking ? LockType.EXCLUSIVE : LockType.EXCL_WRITE, blocking ? LockState.WAITING : LockState.ACQUIRED, "default", "tab_acid", null, locks);
In this case the code block inside if (blocking) would not be necessary.
There was a problem hiding this comment.
in case of blocking flow, 1st step was to check if we'll be blocked/waiting on prev txn, then commit blocking txn and proceed with the current one. At that step, we should have a lock.
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
…iewed by Antal Sinkovits, Laszlo Vegh) Closes apache#3089
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…iewed by Antal Sinkovits, Laszlo Vegh) Closes apache#3089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Modify the REPLACE/RENAME COLUMNS operation to not acquire EXCLUSIVE lock limiting the system concurrency.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests