HIVE-26041: Fix wrong type supplied for getLatestCommittedCompaction #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should use preparedStatement.setLong() to set correct type for CC_ID.
kgyrtkirk
added
tests pending
tests failed
tests passed
and removed
tests pending
tests failed
labels
nrg4878
approved these changes
Mar 21, 2022
|
Change looks good to me. +1 |
|
Fix has been merged. Please close the jira and the PR. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use preparedStatement.setLong() to set correct type for CC_ID.
What changes were proposed in this pull request?
To fix a type error in prepared statement.
Why are the changes needed?
Most databases need correct type casting. I tested on PostgresSQL and the sql query for retrieving the latest compaction would fail.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added one more test case for compaction id filter.