Hive 18832 #318
Closed
Hive 18832 #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ID tables. License + rename
sankarh
reviewed
Mar 9, 2018
| txnHandler.markCompacted(ci); | ||
| txnHandler.setRunAs(ci.id, System.getProperty("user.name")); | ||
|
|
||
| assertCleanerActions(6); |
There was a problem hiding this comment.
Why the number of files 6 in some test and 4 in some? The number of base/delta files added looks same.
There was a problem hiding this comment.
thats what existing passing tests create in cleaner and using the same here.
| */ | ||
| int recycle(Path path, RecycleType type, boolean ifPurge) throws MetaException { | ||
| public int recycle(Path path, RecycleType type, boolean ifPurge) throws IOException { |
There was a problem hiding this comment.
Why try-catch moved to callers?
There was a problem hiding this comment.
since acid Cleaner does not support the metaexception its moved to other places from the base method which throws compatible exception for both use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support change management for trashing data files from ACID tables.