HIVE-26147: OrcRawRecordMerger throws NPE when hive.acid.key.index is missing for an acid file #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRawRecordMerger.java
Outdated
Show resolved
Hide resolved
asolimando
changed the title
kgyrtkirk
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
amansinha100
approved these changes
Apr 19, 2022
klcopp
approved these changes
Apr 19, 2022
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
… missing for an acid file (Alessandro Solimando, reviewed by Aman Sinha and Karen Coppage) Closes apache#3219.
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
… missing for an acid file (Alessandro Solimando, reviewed by Aman Sinha and Karen Coppage) Closes apache#3219.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JIRA ticket for details.
The PR is split into distinct commits to ease the review process.
TestOrcRawRecordMergerto remove some warningsTestOrcRawRecordMergerto improve readability and allow to more easily add the new testWhat changes were proposed in this pull request?
If the metadata is missing, set min/max keys to null (=> full file scan).
Why are the changes needed?
To fix NPE.
Does this PR introduce any user-facing change?
No
How was this patch tested?
mvn test -Dtest=TestOrcRawRecordMerger -pl ql