HIVE-26190: Implement create iceberg table with metadata location #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvary
reviewed
May 2, 2022
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
May 2, 2022
...rg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
Show resolved
Hide resolved
pvary
reviewed
May 2, 2022
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
pvary
reviewed
May 5, 2022
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
May 5, 2022
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
May 5, 2022
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
May 5, 2022
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
May 5, 2022
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
Show resolved
Hide resolved
pvary
reviewed
May 5, 2022
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
Show resolved
Hide resolved
pvary
reviewed
May 5, 2022
...rg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
Show resolved
Hide resolved
kgyrtkirk
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
pvary
approved these changes
May 6, 2022
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
…pache#3259) (Laszlo Pinter, reviewed by Peter Vary)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…pache#3259) (Laszlo Pinter, reviewed by Peter Vary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Provide support for creating iceberg tables using existing metadata
Why are the changes needed?
To be able to reuse any metadata.
Does this PR introduce any user-facing change?
CREATE TABLE icebergTbl STORED BY ICEBERG TBLPROPERTIES('metadata_location'='some_location')is now supported on Hive Catalog tables.How was this patch tested?
Manual test, unit test