HIVE-24598: handle null in trim function #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests failed
and removed
tests pending
tests failed
labels
kgyrtkirk
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
soubhik-c
force-pushed
the
HIVE-24598-trimfunction
branch
from
7940be6
to
a69c4c9
Compare
kgyrtkirk
added
tests failed
tests pending
tests passed
and removed
tests pending
tests failed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
NULL is a special value in SQL and therefore trim function should return NULL instead of error out.
Why are the changes needed?
Argument object inspector now accommodates NULL value as VOID type.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added ptest with additional cases.