Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-26272: inline util code that is used from log4j jar #3330

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

pjfanning
Copy link
Contributor

What changes were proposed in this pull request?

The use of log4j util code in Hive causes some trouble in Drill - see HIVE-26272

Why are the changes needed?

Apache Drill issues

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI build

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing harm in doing so, if it makes some other project happy, but on initial sight it looks like problem on the drill side only, that they ditches some class or so. didn't read much though...

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1(Pending tests)

@ayushtkn ayushtkn merged commit 08fa19f into apache:master Jun 1, 2022
@pjfanning pjfanning deleted the inline-log4j-code branch June 1, 2022 20:47
DongWei-4 pushed a commit to DongWei-4/hive that referenced this pull request Oct 28, 2022
dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants