HIVE-26274: No vectorization if query has upper case window function #3332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasakrisz
force-pushed
the
HIVE-26274-master-row_number
branch
from
50c7073
to
9daaf1d
Compare
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
abstractdog
approved these changes
Jun 2, 2022
|
LGTM, thanks for the patch @kasakrisz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Convert window function names to lower case when looking up in vectorizable function registry.
Why are the changes needed?
Support case insensitivity of window functions when vectorizing PTF operator.
Does this PR introduce any user-facing change?
No, but explain vectorization output may change if query has window functions
How was this patch tested?