Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-26296: RuntimeException when executing EXPLAIN CBO JOINCOST on query with JDBC tables #3349

Closed
wants to merge 1 commit into from

Conversation

zabetak
Copy link
Contributor

@zabetak zabetak commented Jun 7, 2022

What changes were proposed in this pull request?

Compute selectivity for all types of joins in the same way. I don't see a particular reason to throw an exception when the Join operator is not an instance of HiveJoin.

Why are the changes needed?

Avoid RuntimeException when computing statistics for queries with more than HiveXX operators.

Does this PR introduce any user-facing change?

No

How was this patch tested?

mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=cbo_jdbc_joincost.q

The test fails with a RuntimeException without the changes in this PR.

Copy link
Member

@asolimando asolimando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the reason either for throwing an exception on join classes other than HiveJoin, the change LGTM

Copy link
Contributor

@kasakrisz kasakrisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zabetak zabetak closed this in efae863 Jun 9, 2022
@zabetak zabetak deleted the HIVE-26296 branch June 9, 2022 10:09
DongWei-4 pushed a commit to DongWei-4/hive that referenced this pull request Oct 28, 2022
…uery with JDBC tables (Stamatis Zampetakis, reviewed by Alessandro Solimando, Krisztian Kasa)

Compute selectivity for all types of joins in the same way. There is no
particular reason to throw an exception when the Join operator is not
an instance of HiveJoin.

Closes apache#3349
dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Dec 15, 2022
…uery with JDBC tables (Stamatis Zampetakis, reviewed by Alessandro Solimando, Krisztian Kasa)

Compute selectivity for all types of joins in the same way. There is no
particular reason to throw an exception when the Join operator is not
an instance of HiveJoin.

Closes apache#3349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants