New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-26319: Iceberg integration: Perform update split early #3362
Merged
kasakrisz
merged 23 commits into
apache:master
from
kasakrisz:HIVE-26319-master-iceberg-split-update
Jun 29, 2022
Merged
HIVE-26319: Iceberg integration: Perform update split early #3362
kasakrisz
merged 23 commits into
apache:master
from
kasakrisz:HIVE-26319-master-iceberg-split-update
Jun 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasakrisz
force-pushed
the
HIVE-26319-master-iceberg-split-update
branch
from
June 14, 2022 07:52
e4d316c
to
1f134f9
Compare
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
Jun 14, 2022
kasakrisz
force-pushed
the
HIVE-26319-master-iceberg-split-update
branch
from
June 16, 2022 05:04
1f134f9
to
04ee389
Compare
kgyrtkirk
added
tests pending
tests failed
tests unstable
and removed
tests unstable
tests pending
tests failed
labels
Jun 16, 2022
pvary
reviewed
Jun 16, 2022
...erg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jun 16, 2022
...erg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jun 16, 2022
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jun 16, 2022
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
Outdated
Show resolved
Hide resolved
kasakrisz
force-pushed
the
HIVE-26319-master-iceberg-split-update
branch
from
June 16, 2022 09:28
04ee389
to
39d5ec4
Compare
pvary
reviewed
Jun 16, 2022
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jun 16, 2022
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
Jun 16, 2022
This reverts commit 885e77c.
kasakrisz
force-pushed
the
HIVE-26319-master-iceberg-split-update
branch
from
June 28, 2022 10:50
bb159c1
to
7f1101f
Compare
…Status.State runState)
kgyrtkirk
added
tests failed
tests pending
tests unstable
tests passed
and removed
tests pending
tests failed
tests unstable
labels
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rewrite update statements of iceberg tables to multi insert statement similarly in case of native acid tables.
When generating the rewritten statement:
When executing the multi insert:
FilesForCommit
if both writers are run in the same task.FileSinkOperator
creates its own jobConf instance because the iceberg write operation is stored in it and it is different in both instance.Why are the changes needed?
See #2855
Does this PR introduce any user-facing change?
No.
How was this patch tested?