HIVE-26373: ClassCastException while inserting Avro data into Hbase table for nested struct with Timestamp #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zabetak
reviewed
Jul 6, 2022
hbase-handler/src/test/results/positive/hbase_avro_nested_timestamp.q.out
Outdated
Show resolved
Hide resolved
itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseTestSetup.java
Outdated
Show resolved
Hide resolved
itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseTestSetup.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
|
Hive has been always converting data from local time zone to UTC when writing and from UTC to local time zone when reading. I updated the way the the timestamp is stored in HBase (fc9bc94) to make it coherent with the way it is read by the query. There are properties and Avro file metadata which can control if we want to perform the conversion or not (e.g., |
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
…le with Avro data (Soumyakanti Das reviewed by Stamatis Zampetakis) Closes apache#3418
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…le with Avro data (Soumyakanti Das reviewed by Stamatis Zampetakis) Closes apache#3418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
isPrimitivereturnstruefor TimestampWhy are the changes needed?
isPrimitivewas returningfalseand because of thatTimestamptype was not getting converted toLazyTimestampDoes this PR introduce any user-facing change?
No
How was this patch tested?
mvn test -Dtest=TestHBaseCliDriver -Dtest.output.overwrite=true -Dqfile=hbase_avro_nested_timestamp.q