Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-26401: Refine the log of add_partitions if the partition already exists #3447

Closed
wants to merge 1 commit into from

Conversation

wecharyu
Copy link
Contributor

What changes were proposed in this pull request?

  1. check if the table if a partitioned table before execute add_partitions.
  2. only log the full table name and partition names if the partition already exists.

Why are the changes needed?

To improve the log preservation and readability.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Only refine the log, do not add any tests.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better not to mix two thing: refactor & log stuff together. Can you just restrict this PR to just Log refinement

@wecharyu
Copy link
Contributor Author

Better not to mix two thing: refactor & log stuff together. Can you just restrict this PR to just Log refinement

Hi @ayushtkn , do you mean do not refactor validatePartition() method in this PR? I make this refactor to get partition keys from table, how about logging partition information in the format tableName[part_val1,part_val2...] without refactor?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

@github-actions github-actions bot added the stale label Sep 29, 2022
@github-actions github-actions bot closed this Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants