HIVE-26412: Create interface to fetch available slots and add the default implementation #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abstractdog
reviewed
Jul 20, 2022
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezAvailableSlotsCalculator.java
Outdated
Show resolved
Hide resolved
|
|
||
| void initialize(Configuration conf); | ||
|
|
||
| int getAvailaleSlots(InputInitializerContext inputInitializerContext); |
There was a problem hiding this comment.
@adesh-rao : could you please describe this scenario and a possible implementation class further?
jira description implies that you want to get rid of tightly coupled tez input context, but the interface has tez InputInitializerContext in the signature, so I don't think we addressed the original description
There was a problem hiding this comment.
Removed the dependency of tez input context on the interface.
kgyrtkirk
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
guptanikhil007
approved these changes
Jul 21, 2022
sankarh
approved these changes
Jul 25, 2022
|
@abstractdog Please can you review this request? |
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
…ault implementation (Adesh Rao, reviewed by Laszlo Bodor, Nikhil Gupta, Sankar Hariappan)) Signed-off-by: Sankar Hariappan <sankarh@apache.org> Closes (apache#3456)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…ault implementation (Adesh Rao, reviewed by Laszlo Bodor, Nikhil Gupta, Sankar Hariappan)) Signed-off-by: Sankar Hariappan <sankarh@apache.org> Closes (apache#3456)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HiveSplitGenerator is tightly coupled with Tez's InputContext to fetch the available slots during split calculation. Creating a interface to fetch the available slots will allow having other implementation too which are more suitable for different cloud vendors.
The change contains a default implementation using Tez's InputContext and a new HiveConfiguration pointing to the class implementing the interface. Different cloud vendors can plugin there strategy by implementing the interface.