Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-26363: converting replLogger time format from epoch to UTC #3541

Merged
merged 3 commits into from Aug 22, 2022

Conversation

Rakshith606
Copy link
Contributor

@Rakshith606 Rakshith606 commented Aug 22, 2022

What changes were proposed in this pull request?

converted the time logged in replState from epoch to UTC

Why are the changes needed?

to improve debuggability.

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Contributor

@pudidic pudidic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall code looks good. I added few minor comments about code format.

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pudidic
Copy link
Contributor

pudidic commented Aug 22, 2022

Looks good to me. As it's a trivial change, I'll just merge it.

@pudidic pudidic merged commit 27490a8 into apache:master Aug 22, 2022
DongWei-4 pushed a commit to DongWei-4/hive that referenced this pull request Oct 28, 2022
…he#3541)

HIVE-26363: converting replLogger time format from epoch to readable UTC (Rakshith Chandraiah, reviewed by Teddy Choi)
dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Dec 15, 2022
…he#3541)

HIVE-26363: converting replLogger time format from epoch to readable UTC (Rakshith Chandraiah, reviewed by Teddy Choi)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants