HIVE-26573: Fix ClassCastException issues for Decimal64 vectorization. #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A ClassCastException error was being thrown while deserializing a Decimal64Vector. It is unnecessary for the code to check the DataTypePhysicalVariation property within VectorDeserializeRow. There is already enough information to determine that the binding should bedone with the Decimal64Vector. So the code now just checks for the instance when deciding on the binding. Another bug was found while implementing this fix. The Lazy reads were always converting the decimal into its decimal64 form which isn't necessary when there is no decimal64 binding. This code is now pushed into VectorDeserializeRow which is the only place in the repository which references this variable.
kgyrtkirk
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
|
+1 Looks good to me. But there's a failing test on Jenkins. It ran successfully on my laptop multiple times. Could you push it with a new empty commit to re-trigger the CI? You can use |
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
|
Kudos, SonarCloud Quality Gate passed!
|
pudidic
approved these changes
Oct 21, 2022
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
okumin
pushed a commit
to zookage/hive
that referenced
this pull request
Feb 18, 2023
apache#3630) (cherry picked from commit d3c35ff)
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ClassCastException error was being thrown while deserializing a Decimal64Vector.
It is unnecessary for the code to check the DataTypePhysicalVariation property within VectorDeserializeRow. There is already enough information to determine that the binding should bedone with the Decimal64Vector. So the code now just checks for the instance when deciding on the binding.
Another bug was found while implementing this fix. The Lazy reads were always converting the decimal into its decimal64 form which isn't necessary when there is no decimal64 binding. This code is now pushed into VectorDeserializeRow which is the only place in the repository which references this variable.
What changes were proposed in this pull request?
See commit description
Why are the changes needed?
See commit description
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test added