HIVE-26572: Support constant expressions in vectorization #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests failed
tests unstable
tests passed
and removed
tests pending
tests failed
tests unstable
tests passed
labels
asolimando
force-pushed
the
master-HIVE-26572-constant_support_vectorization
branch
from
54551cb
to
80d4390
Compare
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
tests unstable
labels
deniskuzZ
reviewed
Oct 20, 2022
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java
Show resolved
Hide resolved
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
Kudos, SonarCloud Quality Gate passed!
|
|
+1 LGTM. I love VectorAggregationDescBuilder. It's much clearer now. |
asolimando
requested review from
deniskuzZ
and removed request for
abstractdog
deniskuzZ
changed the title
asolimando
deleted the
master-HIVE-26572-constant_support_vectorization
branch
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
… Solimando, reviewed by Denys Kuzmenko, Teddy Choi) Closes apache#3637
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
… Solimando, reviewed by Denys Kuzmenko, Teddy Choi) Closes apache#3637
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
… Solimando, reviewed by Denys Kuzmenko, Teddy Choi) Closes apache#3637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Vectorization support for multi-parameter UDAF if the extra parameters, other then the aggregation column, are all constants.
Why are the changes needed?
Remove ad-hoc handling of such case and enables more vectorization opportunities.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
mvn test -Dtest='TestVectorGroupByOperator' -pl qlwhere two new unit tests have been added (testInstantiateExpressionMonoParameterExpression,testInstantiateExpressionMonoParameterWhenAlternativesandtestInstantiateExpressionMultiParameterExpression)Qtests affected by the change (the constant parameter
numThreadsforVectorUDAFBloomFilterMergeis now available in theEXPLAINplan since it's backed into the aggregation itself instead of being added a posteriori):