HIVE-19812 : Disable external table replication by default via a coniguration property #365
Conversation
| .run("import table " + replDbName + ".t2 from " + exportDataPath) | ||
| .run("select * from " + replDbName + ".t2") | ||
| .verifyResults(new String[] { "1", "2" }) | ||
| .runFailure("import table " + replDbName + ".t3 from " + exportDataPathRepl) |
There was a problem hiding this comment.
Export already failed for this path exportDataPathRepl. No point in importing from this path.
There was a problem hiding this comment.
its ok to have import
| @@ -482,6 +483,11 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal | |||
| REPL_ADD_RAW_RESERVED_NAMESPACE("hive.repl.add.raw.reserved.namespace", false, | |||
| "For TDE with same encryption keys on source and target, allow Distcp super user to access \n" | |||
| + "the raw bytes from filesystem without decrypting on source and then encrypting on target."), | |||
| REPL_INCLUDE_EXTERNAL_TABLES("hive.repl.dump.include.external.tables", false, | |||
There was a problem hiding this comment.
Name can be hive.repl.include.external.tables. Shall remove "dump"
| primary = new WarehouseInstance(LOG, miniDFSCluster, overridesForHiveConf); | ||
| replica = new WarehouseInstance(LOG, miniDFSCluster, overridesForHiveConf); | ||
| externalDump = new WarehouseInstance(LOG, miniDFSCluster, overridesForHiveConfDump); |
There was a problem hiding this comment.
Instead of another WarehouseInstance, shall pass the new config as an option to WITH clause for REPL DUMP.
| } | ||
|
|
||
| @Test | ||
| public void testDumpExternalTableSetTrue() throws Throwable { |
There was a problem hiding this comment.
Shall merge into 1 test case where pass different configs in WITH clause.
There was a problem hiding this comment.
2 test is cleaner
| .run("show tables like 't2'") | ||
| .verifyFailure(new String[] {"t2"}); | ||
|
|
||
| tuple = primary.run("use " + primaryDbName) |
There was a problem hiding this comment.
Shall also test incremental dump with new config=true and metadata_only=false.
| @@ -176,6 +177,12 @@ public static Boolean shouldReplicate(ReplicationSpec replicationSpec, Table tab | |||
| return false; | |||
| } | |||
|
|
|||
| if (!hiveConf.getBoolVar(HiveConf.ConfVars.REPL_INCLUDE_EXTERNAL_TABLES) && | |||
There was a problem hiding this comment.
Can move this check inside below if block for replicationSpec.isInReplicationScope().
maheshk114
force-pushed
the
BUG-104223
branch
2 times, most recently
from
13b2b64
to
f5a72a6
Compare
…iguration property
…iguration property : ptest fixes
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
use a hive config property to allow external table replication. set this property by default to prevent external table replication.
for metadata only hive repl always export metadata for external tables.