HIVE-26640:Upgrade JUnit to 4.13.2 due to medium CVEs #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Please review this |
|
@nrg4878 Please see this |
|
Could we remove https://github.com/apache/hive/blob/master/packaging/pom.xml#L174-L178 as well? seems this has transitive dependencies to JUnit, we do not need these in runtime. Others look good to me! |
cnauroth
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
+1 (non-binding), pending resolution of feedback from @dengzhhu653 . I applied the patch locally and ran multiple tests successfully. Thank you, @devaspatikrishnatri !
nrg4878
approved these changes
Oct 31, 2022
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
* HIVE-26640:Upgrade JUnit to 4.13.2 due to medium CVEs * HIVE-26640:Upgrade JUnit to 4.13.2 due to medium CVEs
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Dec 29, 2022
* HIVE-26640:Upgrade JUnit to 4.13.2 due to medium CVEs * HIVE-26640:Upgrade JUnit to 4.13.2 due to medium CVEs (cherry picked from commit 1b13f79)
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
* HIVE-26640:Upgrade JUnit to 4.13.2 due to medium CVEs * HIVE-26640:Upgrade JUnit to 4.13.2 due to medium CVEs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?