HIVE-26628: Iceberg table is created when running explain ctas command #3745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests failed
and removed
tests pending
tests failed
labels
kasakrisz
force-pushed
the
HIVE-26628-master-explain-iceberg-ctas-v3-expl
branch
from
ed7ce0f
to
7843b53
Compare
kgyrtkirk
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
kasakrisz
force-pushed
the
HIVE-26628-master-explain-iceberg-ctas-v3-expl
branch
from
732850f
to
4cc5f8f
Compare
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kasakrisz
force-pushed
the
HIVE-26628-master-explain-iceberg-ctas-v3-expl
branch
from
e471d72
to
7b91cb9
Compare
deniskuzZ
reviewed
Nov 11, 2022
add q test
kasakrisz
force-pushed
the
HIVE-26628-master-explain-iceberg-ctas-v3-expl
branch
from
f328f1c
to
33a1ec6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Nov 15, 2022
ayushtkn
reviewed
Nov 19, 2022
Comment on lines
+271
to
+288
| Table Parameters: | ||
| COLUMN_STATS_ACCURATE {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\",\"b\":\"true\",\"c\":\"true\"}} | ||
| EXTERNAL TRUE | ||
| bucketing_version -1 | ||
| engine.hive.enabled true | ||
| iceberg.orc.files.only true | ||
| metadata_location hdfs://### HDFS PATH ### | ||
| numFiles 2 | ||
| numRows 2 | ||
| previous_metadata_location hdfs://### HDFS PATH ### | ||
| serialization.format 1 | ||
| storage_handler org.apache.iceberg.mr.hive.HiveIcebergStorageHandler | ||
| table_type ICEBERG | ||
| totalSize 812 | ||
| #### A masked pattern was here #### | ||
| uuid #Masked# | ||
| write.format.default orc | ||
|
|
There was a problem hiding this comment.
@kasakrisz / @deniskuzZ The table created was a v2 table but here the property is missing & we need to set merge-on-read also for any v2 table, those properties also seems missing. Can you folks check
There was a problem hiding this comment.
@ayushtkn
Thanks for the notice.
I try to fix this in a follow-up patch focusing on the way ctas plan is generated and the statement is executed.
https://issues.apache.org/jira/browse/HIVE-26771
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Explain command should not make changes in the catalog.
Does this PR introduce any user-facing change?
No.
How was this patch tested?